Testing docs, use Warp.testWithApplication to prevent race condition#1194
Merged
alpmestan merged 1 commit intohaskell-servant:masterfrom Aug 16, 2019
Merged
Conversation
alpmestan
approved these changes
Aug 16, 2019
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into an issue today running tests based on these examples on Gitlab CI. The tests were either tried too soon or the port was unavailable.
Warp.testWithApplicationseems to take care of order and shutdown.It should also be fine to use hspecs
parallelsince every test gets its own port. I left it out cause it seemed a bit unnecessary for this example.The elasticsearch example is not updated and still uses bracket. It didn't seem entirely straightforward to implement due to the setting of the port with the action.