fix SDL_CONTROLLERAXISMOTION/ControllerAxisEvent#218
Merged
ocharles merged 1 commit intohaskell-game:masterfrom Oct 28, 2020
Merged
fix SDL_CONTROLLERAXISMOTION/ControllerAxisEvent#218ocharles merged 1 commit intohaskell-game:masterfrom
ocharles merged 1 commit intohaskell-game:masterfrom
Conversation
Contributor
|
Is it possible to get this merged, please? |
Member
|
This looks reasonable to me. |
Member
|
I can't cut a release tonight, but will try and get it out tomorrow.
…On Wed, 28 Oct 2020, at 12:12 PM, Joe Hermaszewski wrote:
Is it possible to get this merged, please?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#218 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFDDQEK2PQGC6L7SVUHJ3SNADBRANCNFSM4NTJO2TA>.
|
Contributor
|
Thanks! |
Member
|
Sorry, didn't quite make the promise of "tomorrow", but this is now on Hackage as 2.5.3.0. On the one hand it's a technically breaking change, but I couldn't quite bring myself to submit a major version bump. Hope everyone is ok with this versioning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was wondering why
ControllerAxisEventnever fired, but moving gamepad analog sticks seemed to sendControllerButtonEvent. This fixes that behavior, tested manually.