Skip to content

Bytestring 11 support #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emilypi wants to merge 1 commit into from
Closed

Bytestring 11 support #160

emilypi wants to merge 1 commit into from

Conversation

@emilypi
Copy link
Member

@emilypi emilypi commented Nov 9, 2020 •
edited
Loading

@hvr this should be insta-merge, just bumps the version on bytestring. See #160.

I'm blocked on this due to tasty's unix dependency.

@Bodigrim Bodigrim linked an issue Nov 13, 2020 that may be closed by this pull request
Compatibility with bytestring 0.11 #159
Closed
@Bodigrim
Copy link
Contributor

Bodigrim commented Nov 13, 2020

Since no released GHC enforces bytestring-0.11 Travis build plans stick to bytestring-0.10. It would be nice to test this configuration explicitly, putting an additional constraint set to cabal.haskell-ci and regenerating .travis.yml.

constraint-set bytestring-0.11
  ghc: == 8.6.5
  constraints: bytestring ==0.11.0.0

(I do not expect anything going wrong, unix does not seem to rely on ByteString internals, but just in case)

@Bodigrim Bodigrim mentioned this pull request Nov 14, 2020
Merged
@emilypi
Copy link
Member Author

emilypi commented Nov 14, 2020 •
edited
Loading

@Bodigrim i did some re-orging on my side and need to reopen the pr. i'll copy your comments over.

@emilypi emilypi mentioned this pull request Nov 14, 2020
Closed
@emilypi emilypi closed this Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compatibility with bytestring 0.11

2 participants

@emilypi @Bodigrim