add detach_console flag #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Daniel Brooks's changes, but without adding a new flag for CREATE_NO_WINDOW, which turned out to not be necessary. And, on unix, setsid is called. Tested on Linux and Windows. Fixes #32.
Collaborator
|
I'm still of the opinion that these need to be two separate flags, the reason being: with two flags, getting any combination of behavior is trivial, but with a single flag, users are forced into difficult to use conditional compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Daniel Brooks's changes, but without adding a new flag
for CREATE_NO_WINDOW, which turned out to not be necessary.
And, on unix, setsid is called.
Tested on Linux and Windows.
Fixes #32.