Give a usable buffer to _pipe on Windows #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes haskell#181, the documentation seems to have been misread, the argument to `_pipe` is the number of bytes to reserve for pipe communications, not the number of pipes to create. This ended up making pipes that can only send 2 bytes at a time. Instead use 8k which is the size of the internal Buffers in `Base` which back `I/O` calls.
snoyberg
approved these changes
Jun 7, 2020
Collaborator
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
Super fast fix, thanks!
Collaborator
|
@TerrorJack Could you review if this addresses your issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181, the documentation seems to have been misread, the argument to
_pipeis the number of bytes to reserve for pipe communications, not the number of pipes to create. This ended up making pipes that can only send 2 bytes at a time.The pipes are created in blocking mode, so any write of larger than 2 bytes block and no read returns more than 2 bytes..
Instead use 8k which is the size of the internal Buffers in
Basewhich backI/Ocalls.