Add support for WinIO to process. #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cc @bgamari (I don't know AndreasK github handle). |
Mistuke
commented
May 20, 2020
Mistuke
commented
May 20, 2020
Mistuke
commented
May 20, 2020
Mistuke
commented
May 20, 2020
Mistuke
commented
May 20, 2020
Mistuke
commented
May 20, 2020
Mistuke
force-pushed
the
wip/new-io-manager-support
branch
5 times, most recently
from
3320a25 to
d73130a
Compare
Merged
Contributor
Author
|
Arg... looks like |
Mistuke
force-pushed
the
wip/new-io-manager-support
branch
from
d73130a to
3731a2f
Compare
Mistuke
force-pushed
the
wip/new-io-manager-support
branch
2 times, most recently
from
4645ca5 to
76b157e
Compare
Contributor
Author
|
Looks like I have to drop the test using the new manager explicitly. I will push changes for |
Mistuke
force-pushed
the
wip/new-io-manager-support
branch
3 times, most recently
from
4711f0e to
9dac4b3
Compare
Mistuke
changed the title
Mistuke
force-pushed
the
wip/new-io-manager-support
branch
from
9dac4b3 to
54a004c
Compare
Mistuke
force-pushed
the
wip/new-io-manager-support
branch
from
54a004c to
b790744
Compare
Contributor
Author
|
This should be the final commit. Everything passes with it. |
Collaborator
Contributor
Author
bgamari
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new Asynchronous I/O manager in GHC for Windows[1] to process.
This is required because process uses internal GHC APIs.
Do not merge yet, however goal for this is for GHC 8.12. It is ready for review.
[1] https://gitlab.haskell.org/ghc/ghc/-/merge_requests/1224