sockopt: add IP_DONTFRAG/IP_MTU_DISCOVER option #603
Conversation
thehajime
force-pushed
the
feature-sockopt-df
branch
from
e752584 to
714e97b
Compare
|
Like |
thehajime
force-pushed
the
feature-sockopt-df
branch
from
714e97b to
beaba43
Compare
macOS doesn't set DF-bit by default thus we need an interface to configure the flag. Signed-off-by: Hajime Tazaki <[email protected]>
thehajime
force-pushed
the
feature-sockopt-df
branch
from
beaba43 to
086ca1b
Compare
thanks, I've tried to implement it in the updated patches. pls take a lookt at it. |
| setDontFragment s = when (family == AF_INET) $ | ||
| #if HAVE_DECL_IP_DONTFRAG || HAVE_DECL_IP_MTU_DISCOVER | ||
| setSocketOption s DontFragment 1 | ||
| #else |
There was a problem hiding this comment.
These four lines (#else clause) are not necessary
There was a problem hiding this comment.
if there are OSs/kernels which don't have those sockoption, I guess the compilation fails like below.
Network/Socket/Syscall.hs:138:1: error: [GHC-58481]
parse error (possibly incorrect indentation or mismatched brackets)
|
138 | bind :: SocketAddress sa => Socket -> sa -> IO ()
| ^
I followed the way ipv6only option does in the #else clause to work around this situation.
do you still think it's unnecessary ?
There was a problem hiding this comment.
Never mind.
I misunderstand that you are using setDontFragment here but you are defining it here.
|
Merged. |
2 participants
macOS doesn't set DF-bit by default thus we need an interface to configure the flag.