-
Notifications
You must be signed in to change notification settings - Fork 201
Allow bytestring 0.11 #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So far I've only tested this by running the testsuite locally on a Linux machine. |
|
I took much time to try using bytestring 0.11 but I cannot use it yet. So, I cannot test this PR at this moment, sigh. |
Is your package list up-to-date? After |
|
@kazu-yamamoto resolver: lts-12.24
packages:
- '.'
nix:
packages: [ ncurses ]
# XXX workaround
# https://github.com/commercialhaskell/stack/issues/2245
hide-th-loading: false
extra-deps:
- bytestring-0.11.0.0
- directory-1.3.6.1
- unix-2.7.2.2
- hspec-2.7.4
- hspec-discover-2.7.4
- QuickCheck-2.14.2
- hspec-core-2.7.4
- random-1.2.0
- splitmix-0.1.0.3
allow-newer: true |
|
Great! I made it! |
kazu-yamamoto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merged. Thank you for your contribution! Should I modify the constraint of the current version in Hackage? |
|
Yes, please. Thanks! |
|
Done. |
http://hackage.haskell.org/package/bytestring-0.11.0.0/changelog