Suppress errors from removeFile in UNIX bind #478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removeFile may fail to delete socket because of lack of permissions, and throw an error which is unrelated to bind() itself.
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Aug 12, 2020
Collaborator
|
Rebased and merged. This is a nice catch. Thanks. |
Contributor
Author
|
It causes some tests to fail in dbus if someone tries to build it with the latest network package. Not too urgent, but it could cause issues if stackage tries to build new release. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeFilemay fail to delete socket because of lack of permissions, and throw an error which is unrelated tobind()itself.