-
Notifications
You must be signed in to change notification settings - Fork 201
defining CustomSockOpt again with ViewPatterns. #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If we want, we can make |
treeowl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the COMPLETE pragma in case someone decides to use -Wincomplete-patterns.
|
@treeowl Do you suggest the following? |
|
{-# COMPLETE CustomSockOpt #-} |
|
Good call on |
|
The pattern synonym looks fine. Can't comment on how it all fits with the rest of the library, because I'm not familiar with that. |
Credit: David Feuer <[email protected]>
Co-authored-by: Evan Borden <[email protected]>
4093a62 to
c369cb2
Compare
|
Rebased just in case. |
|
Merged. Thank you for your review! |
As David Feuer suggested in haskell-cafe, the
CustomSockOptpattern can be defined withViewPatterns.Relating to #414.