Don't catch SomeException #411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exception handling was overly broad in some places. We only need to catch `IOException`. `Control.Exception` can be used to catch `IOException`, which requires `ScopedTypeVariables` or we can use `catchIOError`. This commit chooses `catchIOError` for its simplicity.
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Jun 10, 2019
Collaborator
|
Rebased, added two other commits and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception handling was overly broad in some places. We only need to
catch
IOException.Control.Exceptioncan be used to catchIOException, which requiresScopedTypeVariablesor we can usecatchIOError. This commit choosescatchIOErrorfor its simplicity.Closes #376