Add withFdSocket #352
Closed
Add withFdSocket #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fdSocket` is fairly unsafe, because the socket may be finalized (and therefore closed) while the file descriptor is still being used. `withFdSocket` offers a safer way to use the file descriptor.
Collaborator
|
It looks like this accidentally includes commits from #351. Could you rebase those out? |
Contributor
Author
|
It's not an accident. The merge will otherwise be a bit annoying because of the import list changes. Let's resolve the other one first and then rebase this. |
Collaborator
|
@treeowl do you have any interest in continuing this PR, otherwise I'm going to close it as abandoned. |
Collaborator
|
Let's close this. |
Contributor
Author
|
Sorry, missed some notifications. I'd still be interested in rebasing to revive this. |
Contributor
|
What's blocking this? |
Collaborator
Contributor
Author
|
Ugh. I'll get back to it this weekend, really. |
Collaborator
Contributor
|
This is subsumed by #398 |
Collaborator
|
Closing this in favor of #398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fdSocketis fairly unsafe, because the socket may be finalized(and therefore closed) while the file descriptor is still being
used.
withFdSocketoffers a safer way to use the file descriptor.