Using host byte order for PortNumber to fix Ord instance. #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mistuke
approved these changes
Aug 29, 2018
Collaborator
Mistuke
left a comment
Mistuke
left a comment
There was a problem hiding this comment.
Thanks @kazu-yamamoto! Looks good to me. The appveyor failure seems to be a connection issue.
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Aug 30, 2018
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Aug 30, 2018
Collaborator
Author
|
@Mistuke Thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #346.