Skip to content

Conversation

@dxtr
Copy link
Contributor

@dxtr dxtr commented Nov 11, 2016

This solves #226

@kazu-yamamoto kazu-yamamoto self-requested a review December 15, 2017 03:21
@kazu-yamamoto
Copy link
Collaborator

@eborden This PR fails on Windows.

Socket.hsc:355:26: error: '__OpenBSD__' undeclared (first use in this function)

__OpenBSD__ is a just C macro. I don't know why this fails. Do you understand what's going on?

https://ci.appveyor.com/project/eborden/network/build/1.0.182/job/g8lchejtxp4eg120

@kazu-yamamoto
Copy link
Collaborator

One smart guy pointed out that we should use #elif. :-)

Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.
We passed CI tests.

kazu-yamamoto added a commit that referenced this pull request Dec 15, 2017
@kazu-yamamoto
Copy link
Collaborator

Merged.
Thank you for your contribution!

kazu-yamamoto added a commit to kazu-yamamoto/network that referenced this pull request Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants