Zero memory of sockaddr_un if abstract socket #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sorry but I don't understand the original |
Contributor
Author
|
I don't know myself, but I just didn't touch it - the logic is now simply |
|
IIRC, it has to do with osx failing to use the SockAddr if the rest of the memory that is not used for the current type of SockAddr has not been zero'ed. no such requirements on other unixes. (Obviously it would be best not to take this as face value, and test if that's still the case and add a comment in the code if true) |
Collaborator
|
OK. LGTM. I have merged this. |
Collaborator
|
Than you for your contribution! |
eborden
added a commit
that referenced
this pull request
May 17, 2017
* Zero memory of `sockaddr_un` if abstract socket [#220](#220) * Improving error messages [#232](#232) * Allow non-blocking file descriptors via `setNonBlockIfNeeded` [#242](#242) * Update config.{guess,sub} to latest version [#244](#244) * Rename `my_inet_ntoa` to avoid symbol conflicts [#228](#228) * Test infrastructure improvements [#219](#219) [#217](#217) [#218](#218) * House keeping and cleanup [#238](#238) [#237](#237)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An abstract socket is identified by the entire 108 byte sun_path. So, it's really only useful if the memory is zeroed out beforehand.
See
man 7 unix