Change in recv behavior #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 29, 2016 00:15
added 5 commits
July 30, 2016 21:17
enolan
added a commit
to enolan/network
that referenced
this pull request
Aug 3, 2016
enolan
added a commit
to enolan/network
that referenced
this pull request
Aug 3, 2016
enolan
added a commit
to enolan/network
that referenced
this pull request
Aug 3, 2016
enolan
added a commit
to enolan/network
that referenced
this pull request
Aug 3, 2016
kazu-yamamoto
added a commit
that referenced
this pull request
Aug 4, 2016
Refactoring after #216 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #215. The previous duplication will be reintroduced to avoid breaking behaviour changes.
note: This will require refinement of the test case and implementation, but this is a quick and dirty proof of fix for now.