Remove dead occurrences of cygwin32_HOST_OS. #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted recently on the mailing lists in the context of the containers package, there's not much point in retaining support for versions we cannot test. Cygwin has been unsupported by GHC for some time now. CI currently tests network all the way back to GHC 7.0.4. But even in that version, `cygwin32_HOST_OS` is never set. So effectively any occurrence of `|| defined(cygwin32_HOST_OS)` or `&& !defined(cygwin32_HOST_OS)` is equivalent to `|| FALSE` and `&& TRUE`, respectively. On all platforms on all tested versions of GHC. This patch removes these occurrences, thus simplifying, making consistent, less error prone, and more readable the conditionals testing for whether the current platform is Windows.
Collaborator
|
Fantastic! I don't see any reason not to merge this. Any objections @kazu-yamamoto? |
Collaborator
|
No objection and I have merged this pull request. @mboes Thank you for your contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted recently on the mailing lists in the context of the containers
package, there's not much point in retaining support for versions we
cannot test. Cygwin has been unsupported by GHC for some time now. CI
currently tests network all the way back to GHC 7.0.4. But even in that
version,
cygwin32_HOST_OSis never set. So effectively any occurrenceof
|| defined(cygwin32_HOST_OS)or&& !defined(cygwin32_HOST_OS)isequivalent to
|| FALSEand&& TRUE, respectively. On all platformson all tested versions of GHC.
This patch removes these occurrences, thus simplifying, making
consistent, less error prone, and more readable the conditionals testing
for whether the current platform is Windows.