Allow hole filling to deal with recursion#472
Merged
isovector merged 50 commits intohaskell:masterfrom Oct 19, 2020
Merged
Conversation
This changes the heuristics so we get a reasonable fmap @[], but breaks note.
I was forgetting to count destruct as usage
…nguage-server into recursion-frame-wtf
isovector
changed the title
Collaborator
Author
|
Realized there's more infrastructure work I want to do here before merging. Can't figure out how to turn it into a draft PR, sorry. |
(thanks to @i-am-tom for the idea!)
Collaborator
|
I made it a draft, there was a thing on the top right, near where you add reviewers. It looks like plain text, but is clickable |
Collaborator
Author
|
@WorldSEnder would love to have you on board! Feel free to reach out to me (fpslack: isovector, email: [email protected]) if you're interested in helping. |
Tactic tracing
isovector
changed the title
Collaborator
Author
jneira
approved these changes
Oct 19, 2020
Member
jneira
left a comment
jneira
left a comment
There was a problem hiding this comment.
I dont know the tactic plugin code enough to do a proper review but trusting yours 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TOTBWF and I are back with more! This PR enhances the "attempt to fill hole" code action, allowing it to implement self-recursive functions. The generated code ensures recursion occurs only on structurally-smaller values, and preserves the positional ordering of homomorphically destructed arguments.
It's clever enough to implement
foldr:and nontrivial functor instances: