Skip to content

Use ghcide master and prepare hls-plugin-api-0.4.1.0#439

Merged
jneira merged 3 commits intohaskell:masterfrom
jneira:hls-plugin-api-0.4.1
Sep 29, 2020
Merged

Use ghcide master and prepare hls-plugin-api-0.4.1.0#439
jneira merged 3 commits intohaskell:masterfrom
jneira:hls-plugin-api-0.4.1

Conversation

@jneira
Copy link
Member

@jneira jneira commented Sep 27, 2020 •
edited
Loading

@jneira jneira requested a review from alanz September 27, 2020 20:56
alanz
alanz approved these changes Sep 27, 2020
View reviewed changes
Copy link
Collaborator

@alanz alanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Especially as it brings in the file watcher change.

Happy for merge when CI passes

@wz1000
Copy link
Collaborator

wz1000 commented Sep 28, 2020

The failing test should be removed. I think it is not very useful to destruct globals, since they will clutter up every single destruct action.

/cc @isovector

@jneira
Copy link
Member Author

jneira commented Sep 28, 2020

For completeness the failing test is:

tactic
    Can destruct globals:                            FAIL (43.84s)
      test/functional\Tactic.hs:101:
      Expected code action with title Case split on global, not found in []

@isovector
Copy link
Collaborator

isovector commented Sep 28, 2020

It was passing when I wrote it :) but feel free to remove it. @wz1000 's analysis is right!

@jneira
Copy link
Member Author

jneira commented Sep 28, 2020 •
edited
Loading

other option is mark it as knownBroken with a comment; will do if you agree

@wz1000
Copy link
Collaborator

wz1000 commented Sep 28, 2020

I broke it on purpose, I don't think this should ever be fixed.

@jneira jneira merged commit 5729c2e into haskell:master Sep 29, 2020
@jneira jneira deleted the hls-plugin-api-0.4.1 branch September 29, 2020 04:24
@jneira jneira linked an issue Sep 29, 2020 that may be closed by this pull request
Update hls-plugin-api on Hackage #404
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanz alanz alanz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update hls-plugin-api on Hackage ghcide master?

4 participants

@jneira @wz1000 @isovector @alanz