Closed
Conversation
wz1000
approved these changes
Sep 12, 2020
pepeiborra
force-pushed
the
rebase-ghcide
branch
3 times, most recently
from
242d5cc to
87ee28b
Compare
pepeiborra
force-pushed
the
rebase-ghcide
branch
from
87ee28b to
6daf0cf
Compare
Member
|
Hm...formatter test repeats a part of code for an unknown reason... :( |
Merged
wz1000
requested changes
Sep 12, 2020
Collaborator
There was a problem hiding this comment.
There is a rebase error here
We want to generate the hie file even if errors are deferred, or we won't get hovers/definitions/etc. when there are any defered errors.
I've cleaned up the code in haskell/ghcide#784, so #396 supersedes this
Collaborator
Author
|
Closing in favour of #396 |
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
* Allow the withResponse handler to idiomatically return an error
An LSP response message can have either a result or an error
field. Expose this in the handler by having a return type
type ResponseBody resp = Either ResponseError resp
Closes #395
* Apply hint to use lambdacase
* Simplify, based on @ndmitchell review feedback.
* Remove ResponseBody by inlining it, fmap some results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To pick up the relative import path fix