Parameterize the haskell-lsp client config type#416
Parameterize the haskell-lsp client config type#416cocreature merged 1 commit intohaskell:masterfrom
Conversation
|
Makes a lot of sense to me. |
cocreature
left a comment
cocreature
left a comment
There was a problem hiding this comment.
This is going to conflict with #412. Let’s get that one in first and then integrate this on top of it.
So that haskell-language-server can use its own config And separate it out from the IdeConfiguration which is separately set by the InitializeRequest message.
alanz
force-pushed
the
add-config-to-idestate
branch
from
24116bc to
4d6e884
Compare
cocreature
left a comment
cocreature
left a comment
There was a problem hiding this comment.
Looks reasonable, thanks!
I somewhat wonder why we even have the type parameter for the configuration in haskell-lsp? If you need to store state across handlers you can always stuff it in an IORef or something like that. I would expect that almost all LSP servers have more state than just the configuration so it seems odd to give that special treatment.
It seemed to make sense at the time, and is a convenience for off the shelf users of the library. The config change message is part of the spec, after all. But perhaps the overall structure could be reworked, now we know a lot more about the protocol. |
So that haskell-language-server can use its own config And separate it out from the IdeConfiguration which is separately set by the InitializeRequest message.
So that haskell-language-server can use its own config And separate it out from the IdeConfiguration which is separately set by the InitializeRequest message.
So that haskell-language-server can use its own config And separate it out from the IdeConfiguration which is separately set by the InitializeRequest message.
4 participants
So that haskell-language-server can use its own config