This repository was archived by the owner on Jan 2, 2021. It is now read-only.
Workspace roots and getFileExists#412
Merged
cocreature merged 5 commits intohaskell:masterfrom Feb 13, 2020
Merged
Conversation
pepeiborra
force-pushed
the
workspace-roots
branch
from
a4bc441 to
c55ef16
Compare
pepeiborra
commented
Feb 8, 2020
cocreature
approved these changes
Feb 10, 2020
Collaborator
cocreature
left a comment
cocreature
left a comment
There was a problem hiding this comment.
Nice, thank you! A couple of minor style comments and it would be great to have a test for this.
pepeiborra
force-pushed
the
workspace-roots
branch
from
b341a58 to
ef8d754
Compare
Collaborator
Author
|
I'll look at adding some tests tomorrow |
pepeiborra
force-pushed
the
workspace-roots
branch
from
ef8d754 to
6e83c42
Compare
Collaborator
Author
Tests added! |
cocreature
reviewed
Feb 12, 2020
cocreature
reviewed
Feb 12, 2020
Co-Authored-By: Moritz Kiefer <[email protected]>
Left as future work: adding tests for workspace folder notifications
pepeiborra
force-pushed
the
workspace-roots
branch
from
6e83c42 to
390e4a6
Compare
alanz
added a commit
to alanz/haskell-language-server
that referenced
this pull request
Feb 12, 2020
Needs haskell/ghcide#412 to land first, as a basis for the needed changes
Collaborator
|
What is holding this up? I have a PR (#416) that needs to be updated once this lands, so we can select formatters in hls. |
Collaborator
|
@alanz there were changes less than a day ago give us some time please 🙂 Merged now. |
Collaborator
|
@cocreature Thanks. I saw it got updated yesterday, but figured I would give it a kick for time zone differences, so if it was easy to merge it would be done for me to work on it tonight. I was not intending to harras anyone. |
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Add buildifier targets.
The tool allows to check and format BUILD files in the repo.
To check if files are well formatted, run:
bazel run //:buildifier
To fix badly-formatted files run:
bazel run //:buildifier-fix
* Cleanup dade-copyright-headers formatting.
* Fix dade-copyright-headers on files with just the copyright.
* Run buildifier automatically on CI via 'fmt.sh'.
* Reformat all BUILD files with buildifier.
Excludes autogenerated Bazel files.
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* parse lsp client configuration to track workspace roots * Only use Watched files on workspace files * Apply suggestions from code review Co-Authored-By: Moritz Kiefer <[email protected]> * Add tests for watched files Left as future work: adding tests for workspace folder notifications * Add a test for file creation outside workspace Co-authored-by: Moritz Kiefer <[email protected]>
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Add buildifier targets.
The tool allows to check and format BUILD files in the repo.
To check if files are well formatted, run:
bazel run //:buildifier
To fix badly-formatted files run:
bazel run //:buildifier-fix
* Cleanup dade-copyright-headers formatting.
* Fix dade-copyright-headers on files with just the copyright.
* Run buildifier automatically on CI via 'fmt.sh'.
* Reformat all BUILD files with buildifier.
Excludes autogenerated Bazel files.
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* parse lsp client configuration to track workspace roots * Only use Watched files on workspace files * Apply suggestions from code review Co-Authored-By: Moritz Kiefer <[email protected]> * Add tests for watched files Left as future work: adding tests for workspace folder notifications * Add a test for file creation outside workspace Co-authored-by: Moritz Kiefer <[email protected]>
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Add buildifier targets.
The tool allows to check and format BUILD files in the repo.
To check if files are well formatted, run:
bazel run //:buildifier
To fix badly-formatted files run:
bazel run //:buildifier-fix
* Cleanup dade-copyright-headers formatting.
* Fix dade-copyright-headers on files with just the copyright.
* Run buildifier automatically on CI via 'fmt.sh'.
* Reformat all BUILD files with buildifier.
Excludes autogenerated Bazel files.
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* parse lsp client configuration to track workspace roots * Only use Watched files on workspace files * Apply suggestions from code review Co-Authored-By: Moritz Kiefer <[email protected]> * Add tests for watched files Left as future work: adding tests for workspace folder notifications * Add a test for file creation outside workspace Co-authored-by: Moritz Kiefer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a correctness fix for
getFileExistswhen targetting files out of the workspace - they cannot be watched by the client so we need to fall back to the slow path.This is a spinout from the effort to switch to interface files (#355).