3.12 changelogs updated (backport #9908)#9909
Conversation
* Update changelog for 3.12 (and for future WIP 3.12.1.0 cabal-install) * Remove changelog.d files (cherry picked from commit fd82dbe) # Conflicts: # changelog.d/issue-9736 # release-notes/Cabal-3.12.0.0.md # release-notes/WIP-cabal-install-3.12.x.0.md
|
Cherry-pick of fd82dbe has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Was backport the right way to do this? I don't think we want it deleting changelogs for PRs landed in |
|
Then we would have duplicate entries in release notes, am I wrong? (e.g. one on See last sentence in Making a release “C.2 CHANGELOGs” section. |
|
No, it looks like it wants to delete the changelogs for everything committed to |
|
Never mind, spot checks suggest those are just delayed backports and indeed should be deleted. I am left wondering how to fix the conflicts, since they're whole-file changes instead of commit markers. Mergify's a bit confusing. |
|
Yes, next time we will do the sensible stuff and produce a changelog after everything is backported. |
Normally, with git, I'd |
|
Hmm, but that solves only this single failed cherry-pick, which is a part of the big rebase. So I think I'd rather make the whole rebase locally, resolving this conflict and letting rebase continue, and |
|
And I'd first locally squash the 2 commits in #9908 so that the big rebase is just a single cherry pick of the squashed commit onto the master branch. Makes conflict resolution easier. Does it make sense? |
|
The culpirit is #9810, which modified changelog files that we already deleted in 3.12. I am going to open a new PR which should simplify this. |
We need this since we backported PRs after changelog was first generated
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).noNeeds a forward-port to
master.This is an automatic backport of pull request #9908 done by [Mergify](https://mergify.com).