Add TypeAbstractions extension#9502
Merged
mergify[bot] merged 1 commit intohaskell:masterfrom Dec 12, 2023
Merged
Conversation
andreabedini
approved these changes
Dec 8, 2023
Mikolaj
approved these changes
Dec 8, 2023
Member
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
Thank you! As noted by Andrea, a backport would need to be hacked specially, without adding the constructor that would violate PvP. (And, IMHO, having this in 3.10 is worth the extra effort, if we can afford it.)
ffaf1
added a commit
to ffaf1/cabal
that referenced
this pull request
Dec 8, 2023
See haskell#9496. “Backport” of haskell#9502, notice that we are not adding a new constructor, just tweaking `check` behaviour. This is improve UX without breaking changes.
5 tasks
ffaf1
added a commit
to ffaf1/cabal
that referenced
this pull request
Dec 8, 2023
See haskell#9496. “Backport” of haskell#9502, notice that we are not adding a new constructor, just tweaking `check` behaviour. This is improve UX without breaking changes.
mergify
bot
added
the
merge delay passed
Mikolaj
force-pushed
the
add-extension
branch
from
2d52de2 to
800c0c3
Compare
This was referenced Mar 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #9496.
If needed, the correct
cabal checkbehaviour can be backported to 3.10 without adding| TypeAbstractionsconstructor (a breaking change).Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)We do not write tests on adding extensions.QA Notes
mkdir prova && cd provacabal init -nmdefault-extensions: TypeAbstractionsin the executable stanzacabal checkshould not complain withunknown-extension(compare with 3.10 where it does)