testsuite: Be explicit about runtime test dependencies#9439
Merged
mergify[bot] merged 1 commit intohaskell:masterfrom Nov 16, 2023
Merged
testsuite: Be explicit about runtime test dependencies#9439mergify[bot] merged 1 commit intohaskell:masterfrom
mergify[bot] merged 1 commit intohaskell:masterfrom
Conversation
fendor
approved these changes
Nov 13, 2023
Collaborator
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
That's a neat solution! LGTM
mpickering
force-pushed
the
wip/fix-8356
branch
from
f34357b to
fc1999c
Compare
ulysses4ever
approved these changes
Nov 13, 2023
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
Fingers crossed it finally fixes it!
mpickering
force-pushed
the
wip/fix-8356
branch
from
fc1999c to
cda5c34
Compare
Kleidukos
approved these changes
Nov 13, 2023
mpickering
force-pushed
the
wip/fix-8356
branch
from
cda5c34 to
59523e6
Compare
mpickering
force-pushed
the
wip/fix-8356
branch
from
59523e6 to
2492c0b
Compare
mpickering
added
the
merge delay passed
Member
|
We tend to make a bit of ceremony when applying delay_passed, for transparency and mutual trust and to make sure newcomers don't see old PRs and try to emulate our crooked ways. IMHO in this case emergency merge is justified and, by writing this, I hope I fulfilled the ritual. ;) Still time to object and remove the label, though, while the PR is in the queue (and will probably get rebased again). |
Issue haskell#8356 reports occasional errors from running the testsuite about multiple package versions available. This stems from the invokation of `runghc` not being explicit about all dependencies of the testsuite. The solution is provide a component in the cabal file which is explicit about which packages the tests can depend on. This component has a build-depends section which lists all the dependencies that the tests require. It would be better if this component was a library component but we can't do this with a Custom setup because of limitations to do with per-component builds. Then we also enable `-hide-all-packages`, so the dependency will not be available if it is not explicitly listed as a dependency. You could also imagine a future where the Setup.hs script found the test files and compiled a single executable which would run all the tests, rather than invoking runghc on each one individually. Fixes haskell#8356
Mikolaj
force-pushed
the
wip/fix-8356
branch
from
2492c0b to
5c2286a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #8356 reports occasional errors from running the testsuite about multiple package versions available. This stems from the invokation of
runghcnot being explicit about all dependencies of the testsuite.The solution is provide a component in the cabal file which is explicit about which packages the tests can depend on. This component has a build-depends section which lists all the dependencies that the tests require.
It would be better if this component was a library component but we can't do this with a Custom setup because of limitations to do with per-component builds.
Then we also enable
-hide-all-packages, so the dependency will not be available if it is not explicitly listed as a dependency.You could also imagine a future where the Setup.hs script found the test files and compiled a single executable which would run all the tests, rather than invoking runghc on each one individually.
Fixes #8356