explain merge+no rebase in CONTRIBUTING.md#9427
Conversation
ffaf1
left a comment
ffaf1
left a comment
There was a problem hiding this comment.
Hopefully least popular label ever.
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
Thanks 👍 Should have been done along with the change to Mergify config, but now you know I'm bad at docs...
ulysses4ever
changed the title
merge+no rebasemerge+no rebase in CONTRIBUTING.md
|
Uh? I didn't change anything that would cause this? And it looks like they're expected-to-fail tests? |
|
@mergify rebase |
✅ Branch has been successfully rebased |
ulysses4ever
force-pushed
the
contributing-no-rebase
branch
from
57b4e94 to
1a6e055
Compare
mergify
bot
added
the
merge delay passed
|
Let me rebase to repeat CI halted by the curl problem. |
|
@mergify rebase |
and a few typos while reviewing
✅ Branch has been successfully rebased |
Mikolaj
force-pushed
the
contributing-no-rebase
branch
from
1a6e055 to
a7d28ee
Compare
|
Why is it running Validate? I thought @BinderDavid made it so that non-code modifications didn't need to run it. By the way, is it documented? |
I did not do a finegrained analysis on what counts as code and what as documentation. Currently only changes which are restricted to the |
|
There are also READMEs in subdirs and they'd qualify IMHO. |
|
@BinderDavid that would be super helpful, if you have time for it. Thanks for chiming in! |
5 participants
Template Β: This PR does not modify
cabalbehaviour (documentation, tests, refactoring, etc.)Include the following checklist in your PR: