Fix AutogenModulesToggling test#9407
Merged
mergify[bot] merged 1 commit intohaskell:masterfrom Nov 10, 2023
Merged
Conversation
1 task
Collaborator
Author
|
I tested locally to see that reverting #8690 causes this test to fail. |
sergv
approved these changes
Nov 6, 2023
Collaborator
sergv
left a comment
sergv
left a comment
There was a problem hiding this comment.
LGTM! It's much better test now. The previous version was limited by my familiarity with Cabal testing infrastructure.
ulysses4ever
approved these changes
Nov 6, 2023
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
Makes sense to me, thank you!
Collaborator
Author
|
It seems to fail in CI. I will try again locally shortly. |
geekosaur
approved these changes
Nov 6, 2023
Collaborator
Author
|
I think this might be failing on older GHC versions because of a recompilation bug in older GHC versions. I removed the job cancelling logic in CI so I can see the full matrix of GHC versions. |
mpickering
force-pushed
the
wip/autogen-modules-test
branch
3 times, most recently
from
a1d60e6 to
6449aed
Compare
mergify
bot
added
the
merge delay passed
By converting this to a setupTest we use the in-tree Cabal library rather than relying on a proxy of the GHC version to provide the right Cabal library version. Supersedes haskell#9398
Mikolaj
force-pushed
the
wip/autogen-modules-test
branch
from
6449aed to
9d3a7c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By converting this to a setupTest we use the in-tree Cabal library rather than relying on a proxy of the GHC version to provide the right Cabal library version.
Supersedes #9398