PD check: do not treat library names as package names (backport #9132)#9145
Merged
PD check: do not treat library names as package names (backport #9132)#9145
Conversation
5 tasks
Member
|
@fgaz: I think this backport request that you initiated did not go through. Is it fine to ignore so that the PR get published only in cabal 3.12? If so, could you close this PR? |
c4fa368 to
d899e53
Compare
Member
|
@Mikolaj let's get this in 3.10.2. looks like there's a github outage right now so CI doesn't work, I'll rerun later |
Member
|
Sure. It still report "branch is out-of-date", though. |
2 tasks
ab81127 to
05179f6
Compare
Member
|
These look like genuine test failures now, right? A dot missing somewhere? |
05179f6 to
4d0c2ea
Compare
Kleidukos
approved these changes
Sep 6, 2023
Member
|
@fgaz great, you can merge manually |
4d0c2ea to
9093f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9132 done by Mergify.
Cherry-pick of 4aa5f88 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com