Do not check PVP on internal targets (backport of #9004 to 3.10)#9013
Merged
mergify[bot] merged 2 commits intohaskell:3.10from Jun 17, 2023
Merged
Conversation
ffaf1
approved these changes
Jun 12, 2023
Collaborator
ffaf1
left a comment
ffaf1
left a comment
There was a problem hiding this comment.
Fantastic! I could have written it!
Mikolaj
reviewed
Jun 12, 2023
Member
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
It seems to hiccup on some Werror=unused-imports, but otherwise looks fine.
Internal targets: test-suites or benchmarks. See haskell#8361 for rationale. Note that this patch is quite ugly (duplicating allBuildInfo, using list comprehensions, etc.) but we don’t care as everything will be overwritten by a much more sensible reimplementation in haskell#8427.
Kleidukos
force-pushed
the
backport-no-check-pvp-internal-3.10
branch
from
e762fbc to
ad8279f
Compare
Mikolaj
approved these changes
Jun 12, 2023
Member
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
Error: Ambiguous occurrence ‘shrinkBoundedEnum’
geekosaur
reviewed
Jun 12, 2023
|
|
||
| import qualified Data.ByteString.Lazy as BS | ||
| import qualified Data.Map as Map | ||
| import qualified Control.Monad as CM |
Collaborator
There was a problem hiding this comment.
Shouldn't this be indented the same way? (gremlins…)
Collaborator
|
shrinkBoundedEnum was fixed on master btw |
Kleidukos
force-pushed
the
backport-no-check-pvp-internal-3.10
branch
from
7ed7a8e to
584fc87
Compare
mergify
bot
added
the
merge delay passed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport
Internal targets: test-suites or benchmarks.
See #8361 for rationale.
Note that this patch is quite ugly (duplicating allBuildInfo, using list comprehensions, etc.) but we don’t care as everything will be overwritten by a much more sensible reimplementation in #8427.
Please include the following checklist in your PR:
Bonus points for added automated tests!