Do not check PVP on internal targets#9004
Merged
mergify[bot] merged 3 commits intohaskell:masterfrom Jun 11, 2023
Merged
Conversation
Internal targets: test-suites or benchmarks. See haskell#8361 for rationale. Note that this patch is quite ugly (duplicating allBuildInfo, using list comprehensions, etc.) but we don’t care as everything will be overwritten by a much more sensible reimplementation in haskell#8427.
Member
|
So, is it a good idea to include this in cabal 3.10.2.0? Gershom also says it would be useful for Hackage. Any problems with this idea? |
gbaz
approved these changes
Jun 8, 2023
Member
|
And it needs a change to Cabal as well in order for Hackage to benefit from it. |
Kleidukos
approved these changes
Jun 8, 2023
Kleidukos
added
attention: needs-backport 3.12
and removed
attention: needs-review
labels
2 tasks
mergify
bot
added
the
merge delay passed
Member
|
So, do we backport now? If so, let's do |
Collaborator
Author
|
@mergify backport 3.10 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
* Do not check PVP on internal targets Internal targets: test-suites or benchmarks. See #8361 for rationale. Note that this patch is quite ugly (duplicating allBuildInfo, using list comprehensions, etc.) but we don’t care as everything will be overwritten by a much more sensible reimplementation in #8427. * Add changelog for #9004 --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 1cb92a3) # Conflicts: # Cabal/src/Distribution/PackageDescription/Check.hs
Member
|
Uhoh, a merge conflict in the backport. Is it because we should have backported another PR first or is it due to the formatting PR or something yet different? |
Collaborator
Author
|
It is fourmolu. |
Kleidukos
added a commit
to Kleidukos/cabal
that referenced
this pull request
Jun 12, 2023
Internal targets: test-suites or benchmarks. See haskell#8361 for rationale. Note that this patch is quite ugly (duplicating allBuildInfo, using list comprehensions, etc.) but we don’t care as everything will be overwritten by a much more sensible reimplementation in haskell#8427.
Kleidukos
added a commit
to Kleidukos/cabal
that referenced
this pull request
Jun 12, 2023
Internal targets: test-suites or benchmarks. See haskell#8361 for rationale. Note that this patch is quite ugly (duplicating allBuildInfo, using list comprehensions, etc.) but we don’t care as everything will be overwritten by a much more sensible reimplementation in haskell#8427.
mergify bot
added a commit
that referenced
this pull request
Jun 17, 2023
…l-3.10 Do not check PVP on internal targets (backport of #9004 to 3.10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal targets: test-suites or benchmarks.
See #8361 for rationale.
Note that this patch is quite ugly (duplicating allBuildInfo, using list comprehensions, etc.) but we don’t care as everything will be overwritten by a much more sensible reimplementation in #8427.
Please include the following checklist in your PR:
The documentation has been updated, if necessary.N/A, since no warning-specific docs in master, but they have been updated in Reimplementcabal check#8427.QA Notes
cabal get lentilcdinto itbuild-dependssection of thetest-suitestanza, add an unbounded dependencycabal check, it should not complain about missing upper bounds