Conversation
Kleidukos
requested review from
Mikolaj and
ulysses4ever
and removed request for
ulysses4ever
.github/workflows/validate.yml
Outdated
| id: setup-haskell | ||
| with: | ||
| ghc-version: ${{ matrix.ghc }} | ||
| cabal-version: '3.8.1.0' |
There was a problem hiding this comment.
Let's see what CI says. I'm curious if it will twist our hand to bump the cabal version here or not.
There was a problem hiding this comment.
well-spotted, 3.8 has TypeInType
There was a problem hiding this comment.
(My bad, i always rush to hit Comment...) My worry was specifically about the test suite : it's very peculiar about the version of cabal-install you're compiling it with. It now fails with 3.10. You probably will have to try to revert to 3.8 and see if that works...
| , Cabal ^>= 3.10.0.0 | ||
| , Cabal-syntax ^>= 3.10.0.0 | ||
| , Cabal ^>= 3.10 | ||
| , Cabal-syntax ^>= 3.10 |
There was a problem hiding this comment.
I thought this will make no difference. But it's fine this way, i guess.
| -- you have to use the latest cabal-install release | ||
| setup-depends: Cabal == 3.8.*, | ||
| Cabal-syntax == 3.8.*, | ||
| setup-depends: Cabal == 3.10.*, |
There was a problem hiding this comment.
Now this is smart! I could not guess such a solution.
There was a problem hiding this comment.
May this be related the CI old GHCs failure we are seeing right now?
There was a problem hiding this comment.
Yeah, a priori I thought that this would stay as is was, and the cabal-install in the CI would stay 3.8 also. But I must say I have no explanation for this. It's just a hunch.
|
Blocked by ulysses4ever/rere#20 |
|
@Kleidukos there's no ETA for it, so i suggest using allow-newer. That's what I did on master. |
validate.sh
Outdated
| CABAL=cabal | ||
| CABALPLAN=cabal-plan | ||
| JOBS=4 | ||
| JOBS=12 |
There was a problem hiding this comment.
This is bold! You realize that it won't affect the CI, right? 'Cause validate.yml sets its own -j and passes it to this script.
There was a problem hiding this comment.
ergh, yeah it's a remnant from my local development. :)
|
|
| -- you have to use the latest cabal-install release | ||
| setup-depends: Cabal == 3.8.*, | ||
| Cabal-syntax == 3.8.*, | ||
| setup-depends: Cabal ^>= 3.10, |
There was a problem hiding this comment.
So, shall we try reverting this to 3.8? This is completely dark art and only affects custom setup tests, so whatever works IMHO.
|
I'll use GHC 9.6 for the "old GHC" jobs instead of 8.8 |
Kleidukos
force-pushed
the
use-ghc-9.6-in-ci
branch
from
9be4627 to
bd024c9
Compare
ah. okay. |
Kleidukos
force-pushed
the
use-ghc-9.6-in-ci
branch
from
91923cf to
fef89e8
Compare
|
Kleidukos
force-pushed
the
use-ghc-9.6-in-ci
branch
from
a377b02 to
834bf18
Compare
There was a problem hiding this comment.
# This job needs an older ubuntu (16.04) cause # the required old ghcs using the `-dyn` flavour # are not installable from ppa/hvr in newer ones # see https://github.com/haskell/cabal/issues/8011 container: image: phadej/ghc:8.8.4-xenial
@phadej I'm not sure I see a corresponding image in your dockerhub profile for 9.6.1-xenial. What can we do to remedy to this? Also, are you still willing to maintain such images?
There was a problem hiding this comment.
IIRC, there will be no new images.
There was a problem hiding this comment.
I don't think there needs to be new images to achieve what it's supposed to achieve. Also, I don't think this part of the code should have been touched as a part of the backport.
There was a problem hiding this comment.
Feel free to toy with it, I'm out of ideas personally :/
3 participants
Backport of #8840 for the 3.10 branch