ci: use ubuntu-latest instead of ubuntu-18.04#8418
Merged
robx merged 1 commit intohaskell:masterfrom Aug 22, 2022
Merged
Conversation
Builds with ubuntu-18.04 are failing with This is a scheduled Ubuntu-18.04 brownout. due to deprecation of the action runner: actions/runner-images#6002
ulysses4ever
approved these changes
Aug 22, 2022
| validate-old-ghcs: | ||
| name: Validate old ghcs ${{ matrix.extra-ghc }} | ||
| runs-on: ubuntu-18.04 | ||
| runs-on: ubuntu-latest |
Collaborator
There was a problem hiding this comment.
I wonder what’s up with the comment below that claims the job only runs on 16.04. Should it be removed?
Collaborator
Author
There was a problem hiding this comment.
I think it applies to the docker container, i.e., phadej/ghc:8.8.4-xenial is an ubuntu-16.04-based container. https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container
(I'm not entirely clear on which parts run where in that case...)
Mikolaj
approved these changes
Aug 22, 2022
Member
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
LGTM. Please feel free to emergency merge manually.
Member
|
@mergify backport 3.8 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
added a commit
that referenced
this pull request
Aug 30, 2022
ci: use ubuntu-latest instead of ubuntu-18.04 (backport #8418)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds with ubuntu-18.04 are failing with
due to deprecation of the action runner: actions/runner-images#6002
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!