Skip to content

Comments

Simplify -Werror warning#8258

Merged
mergify[bot] merged 1 commit intohaskell:masterfrom
ffaf1:wall-werr-w
Jul 1, 2022
Merged

Simplify -Werror warning#8258
mergify[bot] merged 1 commit intohaskell:masterfrom
ffaf1:wall-werr-w

Conversation

@ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Jun 27, 2022

-W -Wall is too (correctly) refused by Hackage.

Closes #8257.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Minor: not changelog worthy.
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix also the second half of the error message.

@ffaf1 ffaf1 marked this pull request as ready for review June 28, 2022 08:05
@turion
Copy link

turion commented Jun 28, 2022

Another possibility might be joining the warning messages for -Werror and -Werror -W/-Werror -Wall into a single one, triggering only on -Werror.

@ffaf1 ffaf1 changed the title Clarify -Werr plus -W/-Wall warning Simplify -Werror warning Jun 28, 2022
@ffaf1 ffaf1 requested a review from andreasabel June 28, 2022 17:09
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@andreasabel andreasabel added the merge me Tell Mergify Bot to merge label Jul 1, 2022
@mergify mergify bot merged commit be363be into haskell:master Jul 1, 2022
@ffaf1 ffaf1 deleted the wall-werr-w branch July 1, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cabal-install: cmd/check merge me Tell Mergify Bot to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cabal check incorrectly assumes package has -Wall -Werror

5 participants