cabal-check testsuite: add Package/File tests#8250
Merged
mergify[bot] merged 83 commits intohaskell:masterfrom Jul 1, 2022
Merged
cabal-check testsuite: add Package/File tests#8250mergify[bot] merged 83 commits intohaskell:masterfrom
cabal-check testsuite: add Package/File tests#8250mergify[bot] merged 83 commits intohaskell:masterfrom
Conversation
ffaf1
force-pushed
the
cabal-check-testsuite-old-fields
branch
from
8d0eb5e to
29bd336
Compare
3 tasks
ffaf1
force-pushed
the
cabal-check-testsuite-old-fields
branch
8 times, most recently
from
95b5e5a to
df30f37
Compare
ffaf1
changed the title
cabal-check testsuite: add “fields” testscabal-check testsuite: add “ConfigurePackage” tests
ffaf1
force-pushed
the
cabal-check-testsuite-old-fields
branch
3 times, most recently
from
64d1ecc to
0bac9de
Compare
ffaf1
changed the title
cabal-check testsuite: add “ConfigurePackage” testscabal-check testsuite: add Package/File tests
Collaborator
Author
|
I will |
andreasabel
approved these changes
Jul 1, 2022
Member
andreasabel
left a comment
andreasabel
left a comment
There was a problem hiding this comment.
Great work!
Since all these are just tests, I won't read the 300 files line by line, but just give a bona fide approval.
ulysses4ever
approved these changes
Jul 1, 2022
Languages cannot be listed in `default-extensions`.
`description` should be longer than `synopsis`.
On impossible version ranges for internal libraries.
ffaf1
force-pushed
the
cabal-check-testsuite-old-fields
branch
from
6a419e2 to
50138ec
Compare
andreasabel
added
Cabal: tests/package-tests
cabal-install: cmd/check
and removed
attention: needs-review
labels
7 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests cover all
cabal checkchecks not already present in #8248.It is another step towards #8211; the total number of tests added in the two patches is
106105.Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!