Fix race condition in PackageTests/NewBuild/CmdRun/Terminate#8081
Merged
mergify[bot] merged 1 commit intohaskell:masterfrom Apr 4, 2022
Merged
Fix race condition in PackageTests/NewBuild/CmdRun/Terminate#8081mergify[bot] merged 1 commit intohaskell:masterfrom
mergify[bot] merged 1 commit intohaskell:masterfrom
Conversation
The "up and running" file was written before the signal handler was installed, so it was possible for the test to kill the subprocess before, leading to a missed "exiting" line in the output. I hope this fixes the sporadic failures we're seeing (haskell#8080).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "up and running" file was written before the signal handler
was installed, so it was possible for the test to kill the
subprocess before, leading to a missed "exiting" line in the
output.
I hope this fixes the sporadic failures we're seeing (#8080).
(I'm sure it's a good change, just not 100% on whether this
is the problem we saw in CI.)
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!