Merged
Conversation
Closed
Collaborator
Author
|
Ok, this makes everything build successfully on GHC 9.2, tests still fail because of #7987 |
Collaborator
Author
|
The quick way to see the green ticks is https://github.com/haskell/cabal/actions?query=branch%3Aandrea%2Ffix-overlapping-patterns |
Member
|
This pr, like the other ones needs #8000 to run the jobs with the new names which are required |
Member
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
jneira
force-pushed
the
andrea/fix-overlapping-patterns
branch
from
57f7f6c to
f9d0f8c
Compare
Member
|
CI jobs are stuck due to #8000 not merged yet, so let me merge manually. |
Member
|
@Mergifyio rebase |
These two `otherwise`s have been dead code since about 2016 but GHC has started warning about them only since 9.2.
Contributor
✅ Branch has been successfully rebased |
jneira
force-pushed
the
andrea/fix-overlapping-patterns
branch
from
f9d0f8c to
22b700b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two
otherwises have been dead code since about 2016 but GHC hasstarted warning about them only since 9.2.
I have checked that in these cases GHC has always been picking the first matching pattern.