Basic smoke test for cabal sdist --list-sources#5295
Closed
quasicomputational wants to merge 4 commits intohaskell:masterfrom
Closed
Basic smoke test for cabal sdist --list-sources#5295quasicomputational wants to merge 4 commits intohaskell:masterfrom
quasicomputational wants to merge 4 commits intohaskell:masterfrom
Conversation
4 tasks
quasicomputational
force-pushed
the
sdist-test
branch
from
530baf0 to
121c48a
Compare
By having the runner provide it (and hence know the name), it can then normalise any paths that mention the temporary directory without a problem.
quasicomputational
force-pushed
the
sdist-test
branch
from
4db15a5 to
4777abe
Compare
Windows is doing something funny here. Let's find out what it is.
Contributor
Author
|
According to my debugging putStrLn, the contents of Since the globstar patch rewrites the affected code, I'm going to roll up this PR into #5284 and close this one and see if I incidentally fixed it there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!