Skip to content

cabal.release.project: pick newer unix that fixes important bugs on i386 and arm#10664

Merged
mergify[bot] merged 1 commit intomasterfrom
ulysses4ever-newer-unix
Dec 23, 2024
Merged

cabal.release.project: pick newer unix that fixes important bugs on i386 and arm#10664
mergify[bot] merged 1 commit intomasterfrom
ulysses4ever-newer-unix

Conversation

@ulysses4ever
Copy link
Collaborator


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Dec 23, 2024
@mergify mergify bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period labels Dec 23, 2024
@mergify mergify bot merged commit 56594bd into master Dec 23, 2024
@mergify mergify bot deleted the ulysses4ever-newer-unix branch December 23, 2024 09:10
@geekosaur
Copy link
Collaborator

@mergify backport 3.14

@mergify
Copy link
Contributor

mergify bot commented Dec 23, 2024

backport 3.14

✅ Backports have been created

Details

@geekosaur
Copy link
Collaborator

@mergify backport 3.14.1.1

@mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

backport 3.14.1.1

✅ Backports have been created

Details

mergify bot added a commit that referenced this pull request Dec 26, 2024
Backport #10664: cabal.release.project: pick newer `unix` that fixes important bugs on i386 and arm
sternenseemann added a commit to sternenseemann/nixpkgs that referenced this pull request Jan 16, 2025
Cabal has recently introduced a lower bound for unix so a certain bug
fix for 32bit platforms (in combination with a toolchain that sets
_FILE_OFFSET_BITS=64) is included:
haskell/cabal#10664
haskell/cabal#10677

I don't think it's actually possible to encounter this problem with
nixpkgs since we haven't transitioned to 64bit time_t for 32bit
platforms unlike Debian. To prevent confusing behavior in edge cases,
backport the patch to all GHC versions that lack it and lift the bound
on Cabal 3.14 (which is honestly a strange way to “fix” this problem).
sternenseemann added a commit to NixOS/nixpkgs that referenced this pull request Jan 16, 2025
Cabal has recently introduced a lower bound for unix so a certain bug
fix for 32bit platforms (in combination with a toolchain that sets
_FILE_OFFSET_BITS=64) is included:
haskell/cabal#10664
haskell/cabal#10677

I don't think it's actually possible to encounter this problem with
nixpkgs since we haven't transitioned to 64bit time_t for 32bit
platforms unlike Debian. To prevent confusing behavior in edge cases,
backport the patch to all GHC versions that lack it and lift the bound
on Cabal 3.14 (which is honestly a strange way to “fix” this problem).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥 ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants