Add migration guide for #9718#10578
Merged
mergify[bot] merged 4 commits intohaskell:masterfrom Nov 30, 2024
Merged
Conversation
Collaborator
Author
|
Does this need a backport? Or do we always link |
PR haskell#9718 and related PRs reshuffled and refactored Cabal API. This patch adds a simple migration guide for Cabal library users. Authored-by: Maxim Ivanov
ffaf1
force-pushed
the
breaking-changes-3.14
branch
from
7614e7c to
b4c1f10
Compare
Collaborator
Author
|
Check commit by commit, GitHub rich diff gets confused and messes the diff up. |
ulidtko
approved these changes
Nov 22, 2024
Contributor
ulidtko
left a comment
ulidtko
left a comment
There was a problem hiding this comment.
LGTM with a minor nitpick
Co-authored-by: Maxim Ivanov <[email protected]>
Collaborator
Only master, yes. |
ulysses4ever
approved these changes
Nov 22, 2024
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
Terrific! Thanks Francesco and Maxim!
ffaf1
added
squash+merge me
mpickering
reviewed
Nov 22, 2024
Collaborator
|
Thanks for contributing this @ulidtko |
Contributor
|
Ping @ulysses4ever, @Kleidukos, merge any soon? |
Collaborator
|
@ulidtko, thanks for the ping! The funny thing is, despite overwhelming support, we still lack the second review. Maybe @geekosaur?.. |
geekosaur
approved these changes
Nov 30, 2024
mergify
bot
added
merge delay passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the following checklist in your PR:
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).Thanks to the excellent doc contribution by @ulidtko in #10559.