add the applicable new (version 9.10) GHC flags to normaliseGhcArgs (backport #10014)#10106
Merged
mergify[bot] merged 2 commits into3.12from Jun 12, 2024
Merged
add the applicable new (version 9.10) GHC flags to normaliseGhcArgs (backport #10014)#10106mergify[bot] merged 2 commits into3.12from
mergify[bot] merged 2 commits into3.12from
Conversation
…10014) * add the applicable new (versions 9.2 - 9.10) GHC flags to normaliseGhcArgs Actionable flags are: - fdiagnostics-as-json (changes the format GHC outputs its diagnostics) - fprint-error-index-lists (changes the way GHC displays compile time) - fbreak-points (enables/disables break-points in GHCi) - dipe-stats (dumps information about which info tables have IPE information) - ffamily-application-cache (only changes the speed of the compiler) - fprint-redundant-promotion-ticks - show-error-context - unoptimized-core-for-interpreter (only applies to GHCi) * [chore] correct the flag names and add a FUTUREWORK (cherry picked from commit be10be8) # Conflicts: # Cabal/src/Distribution/Simple/Program.hs
Contributor
Author
|
Cherry-pick of be10be8 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
4 tasks
ulysses4ever
approved these changes
Jun 12, 2024
ulysses4ever
added
squash+merge me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue #9729 (blocked by this PR)
Overview
This PR is concerned with updating the
Distribution.Simple.Program.GHCmodule to include flags added since (inclusively) 9.2 intonormalizeGHCArgsand remove flags that have since removed inrenderGhcOptions.The file didn't seem to be updated since ghc 8.10. I hope to address that in this PR.
Actionable flags, as far as I can tell, are (see commit message):
-fdiagnostics-as-json(changes the format GHC outputs its diagnostics)-fprint-error-index-lists=<always|never|auto>(changes the way GHC displays compile time)-fbreak-points(enables/disables break-points in GHCi)-dipe-stats(dumps information about which info tables have IPEinformation)
-ffamily-application-cache(only changes the speed of the compiler)-fprint-redundant-promotion-ticks-fshow-error-context-funoptimized-core-for-interpreter(only applies to GHCi)For a diff of flags between GHC 8.10 and 9.10, see #10014 (comment)
QA notes
cabal-installwith GHC 9.8 and newer must not list the cabal equivalent of the GHCsplit-objsflag, before GHC 9.8 it must list itchanging either of the flags:
-fdiagnostics-as-json-fprint-error-index-lists-fbreak-points-dipe-stats-ffamily-application-cache-fprint-redundant-promotion-ticks-fshow-error-context-funoptimized-core-for-interpretermust not cause recompilation
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
The documentation has been updated, if necessary.This is an automatic backport of pull request #10014 done by [Mergify](https://mergify.com).