Skip to content

auth/ldap: ensure consistent entity aliasing when set from the username#31427

Merged
benashz merged 1 commit intomainfrom
VAULT-38328/ce-ldap-auth-update-mfa-handling
Aug 5, 2025
Merged

auth/ldap: ensure consistent entity aliasing when set from the username#31427
benashz merged 1 commit intomainfrom
VAULT-38328/ce-ldap-auth-update-mfa-handling

Conversation

@benashz
Copy link
Copy Markdown
Contributor

@benashz benashz commented Aug 5, 2025

[ent: a552ac1e80e3d334673c59a5bb825082cd56b1bf]

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

[ent: a552ac1e80e3d334673c59a5bb825082cd56b1bf]
@benashz benashz requested review from a team as code owners August 5, 2025 18:46
@benashz benashz requested a review from angelocordon August 5, 2025 18:46
@vercel
Copy link
Copy Markdown

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 6:46pm

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 5, 2025
@benashz benashz requested a review from fairclothjm August 5, 2025 18:47
@benashz benashz added this to the 1.20.2 milestone Aug 5, 2025
@benashz benashz enabled auto-merge (squash) August 5, 2025 18:48
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 5, 2025

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 5, 2025

Build Results:
All builds succeeded! ✅

@benashz benashz merged commit e2273db into main Aug 5, 2025
103 of 105 checks passed
@benashz benashz deleted the VAULT-38328/ce-ldap-auth-update-mfa-handling branch August 5, 2025 19:14
mickael-hc pushed a commit that referenced this pull request Aug 6, 2025
…me (#31427)

[ent: a552ac1e80e3d334673c59a5bb825082cd56b1bf]
tomcf-hcp pushed a commit that referenced this pull request Aug 6, 2025
…me (#31427) (#31430)

[ent: a552ac1e80e3d334673c59a5bb825082cd56b1bf]

Co-authored-by: Ben Ash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants