Skip to content

Switch from mitchellh/cli to hashicorp/cli#24239

Merged
swenson merged 1 commit intomainfrom
cli-update
Dec 4, 2023
Merged

Switch from mitchellh/cli to hashicorp/cli#24239
swenson merged 1 commit intomainfrom
cli-update

Conversation

@swenson
Copy link
Copy Markdown
Contributor

@swenson swenson commented Nov 22, 2023

@mitchellh suggested we fork cli and switch to that.

Since we primarily use the interfaces in cli, and the new fork has not changed those, this is (mostly) a drop-in replacement.

A small fix will be necessary for Vault Enterprise, I believe.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 22, 2023
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@biazmoreira biazmoreira self-requested a review November 23, 2023 13:19
@mitchellh suggested we fork `cli` and switch to that.

Since we primarily use the interfaces in `cli`, and the new
fork has not changed those, this is (mostly) a drop-in replacement.

A small change fix will be necessary for Vault Enterprise, I believe.
@swenson
Copy link
Copy Markdown
Contributor Author

swenson commented Dec 4, 2023

Thanks! The dependency fix for Vault enterprise is merged, so this should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants