Repository navigation
fix(bedrockagentcore): allow colons in match_value_string regex - #48445
AruneshDwivedi wants to merge 3 commits into
Conversation
…alue_string_list regex The match_value_string and match_value_string_list fields in custom_jwt_authorizer used regex ^[A-Za-z0-9_.-]+$ which rejected colons. However, the AWS API and Console accept colons in these values (e.g. Cognito custom attributes use the 'custom:' prefix, and group names can contain colons like 'myapp:admin:read'). The sibling field inbound_token_claim_name already uses ^[A-Za-z0-9_.-:]+$ which correctly allows colons. This fix adds ':' to the character class in both regex patterns, matching the existing convention. Fixes hashicorp#48428 Signed-off-by: Arunesh Dwivedi <[email protected]>
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
Signed-off-by: Arunesh Dwivedi <[email protected]>
|
Hey @AruneshDwivedi 👋🏻 Thank you for taking the time to raise this! It looks like this is a duplicate of #48437, so I'm going to close this pull request in favor of that one. If you feel I've done this in error, please feel free to open a new pull request and we'd be happy to take another look. |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
The
match_value_stringandmatch_value_string_listfields incustom_jwt_authorizerused the regex^[A-Za-z0-9_.-]+$which rejects colons. But the AWS API and Console accept colons -- for example in OIDC claim strings likehttps://issuer.example.com.Updated the regex to
^[A-Za-z0-9_.:-]+$to allow colons, matching what AWS actually accepts.Fixes the failing test
TestAccBedrockAgentCoreCustomJWTAuthorizer_basic.