(Re)Implement QueryJSON as iter.Seq[NextMessage]#531
Merged
radeksimko merged 3 commits intopre-releasefrom Sep 16, 2025
Merged
Conversation
QueryJSON as LogMsg emitter
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
b3bfedb to
ca4fa35
Compare
ca4fa35 to
9a8d530
Compare
061a850 to
54411be
Compare
ff3f3e6 to
c05687b
Compare
radeksimko
commented
Sep 3, 2025
radeksimko
commented
Sep 3, 2025
SarahFrench
reviewed
Sep 12, 2025
c05687b to
92e0e52
Compare
54411be to
b2ec2f3
Compare
92e0e52 to
4ac3e4d
Compare
4ac3e4d to
4b8c035
Compare
77b8c83 to
9793bd2
Compare
1 task
SarahFrench
approved these changes
Sep 16, 2025
Member
SarahFrench
left a comment
There was a problem hiding this comment.
I've left a nit and question about testing, however I'm happy for this to be merged and have these addressed later if that's necessary.
Member
|
Also, @radeksimko could you please update the PR title to reflect the latest changes? |
QueryJSON as LogMsg emitterQueryJSON as iter.Seq
QueryJSON as iter.SeqQueryJSON as iter.Seq[NextMessage]
Co-authored-by: Sarah French <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example Usage