add test to reproduce issue with signal: broken pipe on graceful shutdown#523
Closed
dastrobu wants to merge 1 commit intohashicorp:mainfrom
Closed
Conversation
|
|
dastrobu
force-pushed
the
test/expected-interrupt-signal,-received-signal-broken-pipe
branch
2 times, most recently
from
728e132 to
127f408
Compare
dastrobu
force-pushed
the
test/expected-interrupt-signal,-received-signal-broken-pipe
branch
from
127f408 to
0b6b493
Compare
Member
|
@dastrobu This looks quite promising. I'll look into this in more detail when I get a moment. Thanks a lot for sharing this test case. |
Author
|
@radeksimko did you have a chance to take a look at this? |
Contributor
|
Thanks a lot for this test! It made it a lot easier to figure out what was going on. I've implemented another test that fits into |
Member
|
Thank you for the repro case - this was really helpful in getting to the root cause and having it fixed, as per #527 That PR already contains more fine-grained unit tests which I'd consider sufficient for avoiding regressions, so I am going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Relates to:
Description
This is a test to show the issue with
signal: broken pipeon graceful shutdown, introduced by #512.The PR only contains a test and no fix yet, as requested per comment from @radeksimko.
The unit test
TestGracefulCancellation_interruption_on_applyusually fails with:expected interrupt signal, received "signal: broken pipe"Although sometimes I have also seen:
expected interrupt signal, received "exit status 255"It seems to depend on timing.
In our production code, we would love to see graceful shutdown being handled correctly, as intended by #512.
However, we are observing
signal: broken pipeand a locked Terraform state, which is what we would like to get rid of to avoid the need to manually unlock the state again.I can try to provide a fix as well if there is some guidance on how to do it.
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.