feat: add graceful shutdown option for apply&destroy#454
Closed
wjf3121 wants to merge 1 commit intohashicorp:mainfrom
Closed
feat: add graceful shutdown option for apply&destroy#454wjf3121 wants to merge 1 commit intohashicorp:mainfrom
wjf3121 wants to merge 1 commit intohashicorp:mainfrom
Conversation
wjf3121
force-pushed
the
main
branch
2 times, most recently
from
3725626 to
905338b
Compare
Member
|
Hello @wjf3121 We decided to take a slightly different approach in #512 to solve the problem which hopefully provides a simpler UX by making the graceful cancellation on by default with a default 60s timeout. Feel free to upgrade to v0.23.0 which was just released and contains the linked change. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behavior of CommandContext is to immediately kill the command process when receiving cancellation signal from the context, which may lead to corrupted terraform state.
This PR adds the option to allow sending interruption signal to the Apply/Destroy command and wait for a graceful period before forcefully killing the process. Note that the option doesn't work on Windows due to the lack of support of sending interrupt signal.