Maintenance and Testing#73
Merged
dlaguerta merged 12 commits intohashicorp:mainfrom May 6, 2024
ksatirli:main
Merged
Conversation
CalebAlbers
approved these changes
Apr 24, 2024
Contributor
CalebAlbers
left a comment
CalebAlbers
left a comment
There was a problem hiding this comment.
Huge thanks for doing this, @ksatirli! I really appreciate the attention to detail in fixing this up 🙂
I'm no longer part of the team required by CODEOWNERS, but giving my +1 as a former maintainer
dlaguerta
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello maintainers 👋🏼
I recently integrated
setup-copywritein the Actions I maintain and noticed a few rough edges that I hope this PR will be able to remove.1.) I've updated the test suite to not just consider
mainon PR andpush, but the currently worked on branch. This should give you more confidence that the PR code is good, before it gets merged. (see.github/workflows/action-unit-test.ymland.github/workflows/action-self-test.yml)2.) I've updated the README example with more up to date versions and fixed na ESLint warning
3.) I've updated the package file with a more appropriate description and version string and updated two
devDeps4.) Finally, I've updated
action.ymlto usenode20as opposed to the deprecatednode16and added branding for easier visual recognition.