Skip to content

fix: type assertion on errors #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tenthirtyam merged 1 commit into from
May 21, 2025
Merged

fix: type assertion on errors #535

tenthirtyam merged 1 commit into from
May 21, 2025

Conversation

@tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented May 21, 2025

Fix the type assertion on errors to use the *object.DatastoreNoSuchDirectoryError pointer.

Follow-up to #530.

~/Downloads/packer-plugin-vsphere git:[fix/type-assertion-on-errors]
go fmt ./...

~/Downloads/packer-plugin-vsphere git:[fix/type-assertion-on-errors]
go fmt ./...

~/Downloads/packer-plugin-vsphere git:[fix/type-assertion-on-errors]
make dev
packer plugins install --path packer-plugin-vsphere "github.com/hashicorp/vsphere"
Successfully installed plugin github.com/hashicorp/vsphere from /Users/johnsonryan/Downloads/packer-plugin-vsphere/packer-plugin-vsphere to /Users/johnsonryan/.packer.d/plugins/github.com/hashicorp/vsphere/packer-plugin-vsphere_v1.4.3-dev_x5.0_darwin_amd64

~/Downloads/packer-plugin-vsphere git:[fix/type-assertion-on-errors]
make build

~/Downloads/packer-plugin-vsphere git:[fix/type-assertion-on-errors]
make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.479s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       5.289s
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/utils [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       10.115s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  3.462s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   8.429s
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       2.988s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      3.777s
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]

~/Downloads/packer-plugin-vsphere git:[fix/type-assertion-on-errors]
golangci-lint run
0 issues.

@tenthirtyam
fix: type assertion on errors
bd7f37e 
Fix the type assertion on errors to use the `*object.DatastoreNoSuchDirectoryError` pointer.

Follow-up to #530.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone May 21, 2025
@tenthirtyam tenthirtyam requested a review from JenGoldstrich May 21, 2025 20:50
@tenthirtyam tenthirtyam self-assigned this May 21, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 21, 2025 20:50
@tenthirtyam tenthirtyam merged commit 617f199 into main May 21, 2025
14 checks passed
@tenthirtyam tenthirtyam deleted the fix/type-assertion-on-errors branch May 21, 2025 22:48
tenthirtyam added a commit that referenced this pull request May 22, 2025
@tenthirtyam
fix: type assertion on errors (#535)
3c2b37f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

tech-debt

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @JenGoldstrich