Skip to content

chore: driver godoc #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbajolet-hashicorp merged 1 commit into from
Jan 27, 2025
Merged

chore: driver godoc #510

lbajolet-hashicorp merged 1 commit into from
Jan 27, 2025

Conversation

@tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Jan 26, 2025

Description

Adds or updates the Go Doc comments for the driver functions.

packer-plugin-vsphere on ο„“ chore/driver-godoc [!] via 🐹 v1.23.5 
➜ go fmt ./...

packer-plugin-vsphere on ο„“ chore/driver-godoc [!] via 🐹 v1.23.5 took 33.2s 
➜ make generate
2025/01/26 14:22:21 Copying "docs" to ".docs/"
2025/01/26 14:22:21 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vsphere on ο„“ chore/driver-godoc [!] via 🐹 v1.23.5 
➜ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/utils[no test files]
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone       1.521s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common      3.187s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       7.178s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  2.710s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   5.762s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.602s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.018s

@tenthirtyam tenthirtyam added this to the v1.5.0 milestone Jan 26, 2025
@tenthirtyam tenthirtyam self-assigned this Jan 26, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner January 26, 2025 19:23
lbajolet-hashicorp
lbajolet-hashicorp previously approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tenthirtyam,

Just have one question/nit left to address, but besides that, LGTM!
Pre-approving for now

@tenthirtyam
Copy link
Collaborator Author

tenthirtyam commented Jan 27, 2025

Hey @tenthirtyam,

Just have one question/nit left to address, but besides that, LGTM! Pre-approving for now

Resolved in a007c32. πŸ˜ƒ

@tenthirtyam @lbajolet-hashicorp
chore: driver godoc
8539009 
Adds or updates the Go Doc comments for the driver functions.

Signed-off-by: Ryan Johnson <[email protected]>
@lbajolet-hashicorp lbajolet-hashicorp merged commit 397ef9b into main Jan 27, 2025
14 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore/driver-godoc branch January 27, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

chore Chore tech-debt

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @lbajolet-hashicorp