fix: improve sata controller error handling #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
force-pushed
the
fix/sata-controller-error-handling
branch
from
f12204c to
612627b
Compare
lbajolet-hashicorp
previously approved these changes
Dec 5, 2024
Contributor
lbajolet-hashicorp
left a comment
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Thanks for the PR @tenthirtyam,
I've left one tiny nitpick on the type check, but besides that, LGTM!
Pre-approving this one
tenthirtyam
force-pushed
the
fix/sata-controller-error-handling
branch
2 times, most recently
from
9e0a0d3 to
b0e4ad9
Compare
tenthirtyam
force-pushed
the
fix/sata-controller-error-handling
branch
from
b0e4ad9 to
e23925f
Compare
- Utilize `errors.Is` for accurate error comparison when checking for `ErrNoSataController`, allowing for correct handling of wrapped errors. - Implement error wrapping with `%w` in `fmt.Errorf` to preserve underlying error information. - Add handling for unexpected error conditions from `FindSATAController` to ensure robustness. Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
fix/sata-controller-error-handling
branch
from
e23925f to
bb56e2f
Compare
lbajolet-hashicorp
approved these changes
Dec 5, 2024
Contributor
lbajolet-hashicorp
left a comment
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Thanks for the reroll @tenthirtyam!
LGTM at first glance, will merge if/when CI goes green :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors.Isfor accurate error comparison when checking forErrNoSataController, allowing for correct handling of wrapped errors.%winfmt.Errorfto preserve underlying error information.FindSATAControllerto ensure robustness.